Fixed prop test not working with DSHOT and some small DSHOT efficiency improvements #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DSHOT has one function, motorsBurstDshot() that sends out all motor signals at once which is a bit different then the timer generated signals. This did not work during the propeller test as the motorsBurstDshot() function was never called. As a fix this was moved to the end of the update loop in stabilizer. At the same time, while debugging, a did some small efficiency improvements. E.g. the DMA reload is only a DMA_Stream->NDTR update instead of a full re-init with DMA_Init(...)