convert alternative pins loco deck to kbuild #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knmcguire
commented
Jul 5, 2022
| @@ -569,7 +569,7 @@ static const DeckDriver dwm1000_deck = { | |||
| .pid = 0x06, | |||
| .name = "bcDWM1000", | |||
|
|
|||
| #ifdef LOCODEC_USE_ALT_PINS | |||
There was a problem hiding this comment.
this was the typo I was referring about
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The loco deck alternative pins setting was not yet configured to kbuild.
I also noticed that somewhere the define had a typo initially, so probably was broken anyway.