Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add throttling for LH2 #1117

Merged
merged 4 commits into from
Sep 21, 2022
Merged

Add throttling for LH2 #1117

merged 4 commits into from
Sep 21, 2022

Conversation

krichardsson
Copy link
Contributor

When 2+ LH V2 base stations are visible a lot of samples are sent to the kalman estimator. This PR adds functionality to discard samples to keep the rate around 50 samples/s

Copy link
Member

@tobbeanton tobbeanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good!
What I'm interested in is how well the throttling works.

  1. I guess you have some graphs you could show?
  2. Should we verify that the samples that are discarded are well distributed?
  3. Are there any edge cases that could be problematic?

PARAM_GROUP_STOP(lighthouse)

LOG_GROUP_START(lighthouse)
LOG_ADD(LOG_FLOAT, disProb, &discardProbability)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a debug log variable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Fixed

@krichardsson krichardsson merged commit 74140e6 into master Sep 21, 2022
@krichardsson krichardsson deleted the krichardsson/lh-throttle branch September 21, 2022 08:27
@krichardsson krichardsson added this to the 2022.12 milestone Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants