Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc updates #1145

Merged
merged 5 commits into from Nov 9, 2022
Merged

Doc updates #1145

merged 5 commits into from Nov 9, 2022

Conversation

knmcguire
Copy link
Member

Just going through some GitHub issues for some documentation updates!

Should fix #1104 #1084

I'll try to combine multiple in one

@knmcguire knmcguire linked an issue Nov 8, 2022 that may be closed by this pull request
toolbelt make_app #1084
Closed
@knmcguire knmcguire marked this pull request as draft November 8, 2022 13:47
@knmcguire
Copy link
Member Author

Also fixes #930... long overdue

@knmcguire
Copy link
Member Author

And this should close #908

@knmcguire knmcguire marked this pull request as ready for review November 8, 2022 14:30
tobbeanton
tobbeanton approved these changes Nov 9, 2022
View reviewed changes
Copy link
Member

@tobbeanton tobbeanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good changes. Nothing to add other then that it looks good!

@knmcguire knmcguire merged commit dbc717a into master Nov 9, 2022
@knmcguire knmcguire deleted the doc-update branch November 9, 2022 14:49
@krichardsson krichardsson added this to the 2022.12 milestone Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobbeanton tobbeanton tobbeanton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2022.12
Development

Successfully merging this pull request may close these issues.

Remove readmes app layer example toolbelt make_app
3 participants
@knmcguire @tobbeanton @krichardsson