Better error handling for scp uploads #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klappradla
reviewed
Oct 15, 2020
| {:exit_status, _, status} -> exited(options, state, status) | ||
| {:eof, _} -> eof(options, state) | ||
| {:closed, _} -> closed(options, state) | ||
| {:data, _, 1, data} -> |
Member
There was a problem hiding this comment.
Note to our future selves: the integer value is the data type of the message:
The valid values are 0 ("normal") and 1 ("stderr")
Up until now, we did not handle messages on stderr.
Contributor
|
This needs rebasing once #166 is merged so we get CI feedback on this. ✌️ |
andreasknoepfle
force-pushed
the
handle-errors-on-scp-upload
branch
from
06f3a24 to
9a69616
Compare
Member
Author
|
Rebased, but there seems to be an issue with the CI. |
andreasknoepfle
force-pushed
the
handle-errors-on-scp-upload
branch
from
9a69616 to
4ac8e01
Compare
andreasknoepfle
force-pushed
the
handle-errors-on-scp-upload
branch
3 times, most recently
from
d9bf5c0 to
0c72ece
Compare
andreasknoepfle
force-pushed
the
handle-errors-on-scp-upload
branch
3 times, most recently
from
4281f25 to
f6c6203
Compare
Continue to collect warnings instead of stopping at the first.
andreasknoepfle
force-pushed
the
handle-errors-on-scp-upload
branch
from
f6c6203 to
e3c6d44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the context of #160 we debugged a bit into certain cases, when we have files that do not exists or when we have no permission.
We have a very first draft in handling those cases.
Probably this is also liked to #62.
Description
We added some clauses that treat output on
stderror warnings that we do not recognize to befataland lead to error output.Motivation and Context
Types of changes
Checklist
## mastersection).