Skip to content

Revert portion of "[Andr][CI] Pom improvements (#103)" #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 7, 2024
Merged

Revert portion of "[Andr][CI] Pom improvements (#103)" #108

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
94e9981
Revert "[Andr][CI] Pom improvements (#103)"
Augustyniak Nov 7, 2024
aa8d52b
Revert "Revert "[Andr][CI] Pom improvements (#103)""
Augustyniak Nov 7, 2024
acd0b5f
revert only portion
Augustyniak Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions platform/jvm/capture-timber/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,6 @@ publishing {
}

// TODO(murki): Using this requires further setup in CI and local (e.g. signing entries in the local gradle.properties file)
signing {
Copy link
Contributor

@murki murki Nov 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can also just comment this section out

Copy link
Contributor

@murki murki Nov 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this is the error

Execution failed for task ':capture-timber:signMavenPublication'.
> Task :capture-timber:signMavenPublication FAILED
> Cannot perform signing task ':capture-timber:signMavenPublication' because it has no configured signatory

and I haven't set up that part yet

Copy link
Contributor Author

@Augustyniak Augustyniak Nov 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kk, will do that

sign(publishing.publications)
}
// signing {
// sign(publishing.publications)
// }
Loading