[Android] Bump min SDK to 24 #484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 APK Size Report
|
FranAguilera
force-pushed
the
franjam/min-sdk-24
branch
from
5b30737 to
d1d724a
Compare
📦 APK Size Report
|
FranAguilera
force-pushed
the
franjam/min-sdk-24
branch
from
ebb5d4e to
a8b2e3f
Compare
📦 APK Size Report
|
1 similar comment
📦 APK Size Report
|
FranAguilera
force-pushed
the
franjam/min-sdk-24
branch
from
5a09e59 to
3c0150f
Compare
* [Android] JankStats - Early flagging * [Android] JankStats - Early flagging * Add junit test
Co-authored-by: Reflejo <232113+Reflejo@users.noreply.github.com>
* Adding native crash processing for Android * Update extension of sample native crash report file * PR feedback. Add binary image and expand unit test * Remove prior isLibrary check * PR feedback, remove filename from source when binary data
📦 APK Size Report
|
|
@FranAguilera did you get any clarify about the SDK size increase? |
My bad, this commit was a bit old so this needs a rebase from latest main for proper comparison |
📦 APK Size Report
|
This looks better now 
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Resolves BIT-5616
Bumps minSdk from 21 to 24. More context on decision
Most relevant changes:
JankStatsMonitorno longer needs a backgroundThread to handle updates on devices below 24.FatalIssueConfigParsercan rely directly now onappContext.dataDir.absolutePath.NetworkAttributesuses nowregisterDefaultNetworkCallbackinstead ofregisterNetworkCallback.Verification
Verified on this session for the gradle test app (checked network logs)
Verified via local maven publish on external app that has min sdk 21. Expected result will fail the build due to min sdk. Instructions here