ci: re-enable android emulator tests #54
Conversation
Augustyniak
force-pushed
the
re-enable-android-emulator-tests
branch
from
60e0d9d to
1079e89
Compare
| uses: reactivecircus/android-emulator-runner@f0d1ed2dcad93c7479e8b2f2226c83af54494915 # pin@v2.32 | ||
| with: | ||
| channel: beta | ||
| channel: stable |
There was a problem hiding this comment.
This is the clue of the change
There was a problem hiding this comment.
dang I wonder why were using beta
| uses: actions/checkout@v4 | ||
|
|
||
| # See https://github.blog/changelog/2023-02-23-hardware-accelerated-android-virtualization-on-actions-windows-and-linux-larger-hosted-runners/ | ||
| - name: Enable KVM group perms |
There was a problem hiding this comment.
Not really required to be a part of this PR but since it effectively doesn't work as we moved to ubuntu-latest recently I decided to clean it up (remove)
There was a problem hiding this comment.
i forgot why we removed using virtualization?
There was a problem hiding this comment.
Moving to ubuntu-latest was fixing another issues that we had while trying to update to the latest version of the NDK https://github.com/bitdriftlabs/capture-sdk/pull/40/files#diff-fc26471d058677138d1caf923b0188a49eaf3437ba2f1cec8a6927ee0a1f0402R88. ubuntu-latest-8-cores didn't have the latest version of NDK available while ubuntu-latest had it.
Now that I am playing with it I cannot even make the gradle_tests CI job work with ubuntu-latest anymore so moving back to -8-cores variant.
.github/workflows/android.yaml
Outdated
| ram-size: 2048M | ||
| arch: x86_64 | ||
| disk-size: 4096M | ||
| disk-size: 8192M |
There was a problem hiding this comment.
is this change related? did it turn out to be an issue with running out of space?
There was a problem hiding this comment.
after moving us from beta to stable release channel I saw some "out of disk space" errors so decided to bump the disk space allocated for the emulator.
It seems that Google has pushed a new
betaversion of the Android emulator. Moving us to astablerelease channel to fix the issue (and reduce the number of possible breakages like that in general).