[Android] Adding back native crash processing #546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FranAguilera
force-pushed
the
franjam/add-back-native-processing
branch
from
ee06a9b to
6fb19d6
Compare
FranAguilera
commented
Aug 1, 2025
...capture/src/main/kotlin/io/bitdrift/capture/reports/persistence/FatalIssueReporterStorage.kt
Outdated
Show resolved
Hide resolved
FranAguilera
force-pushed
the
franjam/add-back-native-processing
branch
from
6fb19d6 to
81a7bd8
Compare
FranAguilera
changed the base branch from
main
to
delisa/bit-5823-bind-async-monitor
FranAguilera
force-pushed
the
franjam/add-back-native-processing
branch
2 times, most recently
from
ce55434 to
dab161b
Compare
📦 Bazel APK(x86_64) Size Report
|
Contributor
Author
heads ups: this is because this PR is on top of #551 |
FranAguilera
force-pushed
the
franjam/add-back-native-processing
branch
3 times, most recently
from
440ea9d to
ca0d844
Compare
murki
reviewed
Aug 6, 2025
platform/jvm/capture/src/main/kotlin/io/bitdrift/capture/reports/FatalIssueReportingMode.kt
Outdated
Show resolved
Hide resolved
murki
reviewed
Aug 6, 2025
platform/jvm/capture/src/main/kotlin/io/bitdrift/capture/reports/FatalIssueReportingMode.kt
Outdated
Show resolved
Hide resolved
murki
reviewed
Aug 6, 2025
platform/jvm/capture/src/main/kotlin/io/bitdrift/capture/Configuration.kt
Outdated
Show resolved
Hide resolved
murki
reviewed
Aug 6, 2025
...capture/src/main/kotlin/io/bitdrift/capture/reports/processor/FatalIssueReporterProcessor.kt
Show resolved
Hide resolved
murki
approved these changes
Aug 7, 2025
Contributor
murki
left a comment
murki
left a comment
There was a problem hiding this comment.
lgtm - except perhaps for the boolean configuration comment
FranAguilera
force-pushed
the
franjam/add-back-native-processing
branch
from
489ef90 to
d774a16
Compare
FranAguilera
force-pushed
the
franjam/add-back-native-processing
branch
from
d774a16 to
f8e082f
Compare
FranAguilera
force-pushed
the
franjam/add-back-native-processing
branch
from
f8e082f to
3fdab79
Compare
📦 Bazel APK(x86_64) Size Report
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds back native crash processing logic + allows extra configuration to opt in for native crashes
Depends on #551
Verification
Please refer to this doc