Skip to content

Conversation

@murki
Copy link
Contributor

@murki murki commented Aug 5, 2025

As reported in #540 junit tests weren't able to be run locally in Android Studio.

We use @Suppress("INVISIBLE_REFERENCE") and friends in in tests which are reported as warnings. Since we are setting allWarningsAsErrors = true in the kotlin compiler this breaks the IDE builds. We need to bypass these particular warnings via the -Xdont-warn-on-error-suppression flag.

Not ideal but we'll have to make due until kotlin has first-class support for "friend" modules to access internal, see: https://youtrack.jetbrains.com/issue/KT-67920/K2-Allow-suppression-of-INVISIBLEREFERENCE-errors

targetCompatibility = JavaVersion.VERSION_1_8
}

// TODO(murki): consider updating to using kotlin.compilerOptions {} block
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@murki murki requested a review from FranAguilera August 5, 2025 00:38
@murki murki enabled auto-merge (squash) August 5, 2025 00:56
@github-actions
Copy link

github-actions bot commented Aug 5, 2025

📦 Bazel APK(x86_64) Size Report

Metric Size (KB)
Baseline 3393
Current 3393
Difference 0

✅ Bazel APK(x86_64) size unchanged.

@murki murki merged commit 002b3c5 into main Aug 5, 2025
14 checks passed
@murki murki deleted the murki/fix-ad-tests branch August 5, 2025 01:15
@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants