Skip to content

Conversation

@FranAguilera
Copy link
Contributor

@FranAguilera FranAguilera commented Aug 6, 2025

TLDR

Follow up to #180

Prevents 2025-08-05 19:39:00.410 okhttp.OkHttpClient W A connection to https://api.bitdrift.io/ was leaked. Did you forget to close a response body? To see where this was allocated, set the OkHttpClient logger level to FINE:

image

Verification

Checking logcat on PR, this warning should be gone

Network spans

@FranAguilera FranAguilera marked this pull request as ready for review August 6, 2025 14:51
@FranAguilera FranAguilera changed the title [Android] Prevent A connection to ... was leaked [Android] Fix OkHttpClient connection leaked Aug 6, 2025
@github-actions
Copy link

github-actions bot commented Aug 6, 2025

📦 Bazel APK(x86_64) Size Report

Metric Size (KB)
Baseline 3393
Current 3393
Difference 0

✅ Bazel APK(x86_64) size unchanged.

Copy link
Contributor

@murki murki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

big if true

@FranAguilera FranAguilera merged commit c54e353 into main Aug 6, 2025
14 checks passed
@FranAguilera FranAguilera deleted the franjam/okhttp-connection branch August 6, 2025 20:27
@github-actions github-actions bot locked and limited conversation to collaborators Aug 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants