android: reorder logger init #694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we initialize logging during JNI_OnLoad we need to configure RUST_LOG early enough in order to be picked up by this initialization code
murki
approved these changes
Oct 9, 2025
FranAguilera
approved these changes
Oct 9, 2025
|
|
||
| // This needs to happen before loading the native library as we set | ||
| // up logging during library initialization. | ||
| setUpInternalLogging(appContext) |
There was a problem hiding this comment.
Can you remove also from LoggerImpl constructor?
Size Comparison Report (x86_64)
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we initialize logging during JNI_OnLoad we need to configure RUST_LOG early enough in order to be picked up by this initialization code
This also changes the build configuration so that we only optimize the release build, as setting opt-level=z seems to disable debug_assertions which compiles out low level logging. As a bonus this should speed up dev builds