Skip to content

Fixing changelog release #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 5, 2025
+9 −2
Merged

Fixing changelog release #736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
55762c7
Fixing changelog release
FranAguilera Nov 5, 2025
ef73ccb
Update comments
FranAguilera Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/changelog_release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,11 @@ jobs:
with:
version: ${{ needs.prepare-release.outputs.version }}
emergency: false
secrets: inherit
# Explicitly pass secrets (instead of secrets: inherit) because reusable workflows
# called from push events may not reliably inherit secrets automatically.
secrets:
OPEN_CAPTURE_SDK_PRS_APP_ID: ${{ secrets.OPEN_CAPTURE_SDK_PRS_APP_ID }}
OPEN_CAPTURE_SDK_PRS_PRIVATE_KEY: ${{ secrets.OPEN_CAPTURE_SDK_PRS_PRIVATE_KEY }}

no-release:
name: No release (tag exists)
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/update_sdk_version.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,10 @@ jobs:
uses: ./.github/workflows/release_gh.yaml
with:
version: ${{ inputs.version }}
secrets: inherit
# Explicitly pass secrets to ensure they're available when called from other workflows
secrets:
OPEN_CAPTURE_SDK_PRS_APP_ID: ${{ secrets.OPEN_CAPTURE_SDK_PRS_APP_ID }}
OPEN_CAPTURE_SDK_PRS_PRIVATE_KEY: ${{ secrets.OPEN_CAPTURE_SDK_PRS_PRIVATE_KEY }}
public-release:
permissions:
id-token: write # required to use OIDC authentication
Expand Down
Loading