Skip to content

[ANDR] Define custom names for all threads managed by the sdk #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 15, 2024
Merged

[ANDR] Define custom names for all threads managed by the sdk #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9d6489
[ANDR] Define custom names for all threads managed by the sdk
murki Oct 11, 2024
a1b30af
fmt
murki Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion platform/jvm/capture/src/main/kotlin/io/bitdrift/capture/LoggerImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,9 @@ internal class LoggerImpl(
fieldProviders: List<FieldProvider>,
dateProvider: DateProvider,
private val errorHandler: ErrorHandler = ErrorHandler(),
processingQueue: ExecutorService = Executors.newSingleThreadExecutor(),
processingQueue: ExecutorService = Executors.newSingleThreadExecutor {
Thread(it, "io.bitdrift.capture.event-listener")
},
sessionStrategy: SessionStrategy,
context: Context = ContextHolder.APP_CONTEXT,
clientAttributes: ClientAttributes = ClientAttributes(
Expand Down
4 changes: 3 additions & 1 deletion platform/jvm/capture/src/main/kotlin/io/bitdrift/capture/network/okhttp/OkHttpNetwork.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,9 @@ internal class OkHttpNetwork(
.retryOnConnectionFailure(false) // Retrying messes up the write pipe state management, so disable.
.build()

private val executor: ExecutorService = Executors.newSingleThreadExecutor()
private val executor: ExecutorService = Executors.newSingleThreadExecutor {
Thread(it, "io.bitdrift.capture.network.okhttp")
}
private val url: HttpUrl =
apiBaseUrl.newBuilder().addPathSegments("bitdrift_public.protobuf.client.v1.ApiService/Mux")
.build()
Expand Down
4 changes: 3 additions & 1 deletion platform/jvm/replay/src/main/kotlin/io/bitdrift/capture/replay/ReplayPreviewClient.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,9 @@ class ReplayPreviewClient(
) : ReplayLogger {

private val replayCapture: ReplayCapture = ReplayCapture(this)
private val executor: ExecutorService = Executors.newSingleThreadExecutor()
private val executor: ExecutorService = Executors.newSingleThreadExecutor {
Thread(it, "io.bitdrift.capture.session-replay-client")
}
private val client: OkHttpClient
private val request: Request
private var webSocket: WebSocket? = null
Expand Down
4 changes: 3 additions & 1 deletion ...jvm/replay/src/main/kotlin/io/bitdrift/capture/replay/internal/ReplayCaptureController.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@ import java.util.concurrent.TimeUnit
// Controls the triggering of screen captures at regular time interval
internal class ReplayCaptureController(
private val mainThreadHandler: MainThreadHandler = MainThreadHandler(),
private val executor: ScheduledExecutorService = Executors.newSingleThreadScheduledExecutor(),
private val executor: ScheduledExecutorService = Executors.newSingleThreadScheduledExecutor {
Thread(it, "io.bitdrift.capture.session-replay")
},
private val sessionReplayConfiguration: SessionReplayConfiguration = ReplayModule.replayDependencies.sessionReplayConfiguration,
private val replayCapture: ReplayCapture = ReplayModule.replayDependencies.replayCapture,
private val runtime: Runtime,
Expand Down
Loading