-
Notifications
You must be signed in to change notification settings - Fork 0
Move bd-bonjson's ffi functionality into a separate crate #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR extracts FFI (Foreign Function Interface) functionality from the bd-bonjson crate into a separate bd-bonjson-ffi crate to resolve duplicate symbol linker errors.
- Moves all FFI-related code from bd-bonjson to a new bd-bonjson-ffi crate
- Updates the Writer API to use a constructor pattern instead of direct struct initialization
- Adjusts test files and build configurations to reference the new crate structure
Reviewed Changes
Copilot reviewed 11 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| bd-bonjson/src/lib.rs | Removes ffi module export |
| bd-bonjson/src/writer.rs | Adds public constructor method for Writer |
| bd-bonjson/src/writer_test.rs | Updates test to use new Writer constructor |
| bd-bonjson-ffi/src/lib.rs | New FFI crate with WriterBufWriterFile wrapper and C bindings |
| bd-bonjson-ffi/include/bd-bonjson/ffi.h | C header file for FFI functions |
| bd-bonjson-ffi/Cargo.toml | New crate configuration |
| bd-bonjson-ffi/build.rs | Build script for generating C bindings |
| bd-bonjson-tests/src/ffi_tests.rs | Updates import to use new FFI crate |
| bd-bonjson-tests/Cargo.toml | Adds dependency on new FFI crate |
| bd-bonjson-tests/build.rs | Updates build dependency path |
| Cargo.toml | Adds new crate to workspace |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
a3c8471 to
63e1b6d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 11 out of 13 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
63e1b6d to
347e51d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 11 out of 13 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
347e51d to
09a1758
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 11 out of 13 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
09a1758 to
812f7e7
Compare
To get around duplicate symbol linker errors in #255