Skip to content

Conversation

@bitfaster
Copy link
Owner

@bitfaster bitfaster commented Jul 24, 2022

Name builder types with a consistent order:

async => cache
scoped => async
atomic => scoped, async

Rename builder extension methods so that methods changing the cache type have prefix 'As', and configuration methods have prefix 'With', e.g.

var lru = new ConcurrentLruBuilder<int, Disposable>()
   .WithAtomicValueFactory()
   .AsAsyncCache()
   .AsScopedCache()
   .WithCapacity(3)
   .Build();

Add descriptive comments to the builder extension methods making it easier to use.

Alex Peck added 2 commits July 24, 2022 16:06
@bitfaster bitfaster changed the title Users/alexpeck/rename2 cleanup builders Jul 24, 2022
@bitfaster bitfaster merged commit 6fc5c51 into main Jul 24, 2022
@bitfaster bitfaster deleted the users/alexpeck/rename2 branch July 24, 2022 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants