-
Notifications
You must be signed in to change notification settings - Fork 39
factory delegate has arg to avoid closure allocs #339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
Re-ran benchmarks, after refactoring item creation inside TryAdd, this actually results in a repeatable speed up for GetOrAdd test cases.
For both cycle and zipf any change is noise. cycle-arg
cycle-main
zipf-arg
zipf-main
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #311: provide an overload that allows passing args into the factory method to avoid closure allocs. This PR so far only addresses the basic support for LRU/LFU instance methods.
To support across the board (builder support, ICache etc.) is a breaking change, and requires further changes to Atomic/Scoped etc.
Some variation on GetOrAdd, but seems to be noise not regression.