Align IAsyncCache.TryRemove overloads with ConcurrentDictionary #473
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide functional parity with
ConcurrentDictionaryforIAsyncCache.TryRemove, following the implementation forICachein #394.AsyncAtomicFactoryimplementsIEquatableto compare wrapped values. Values that are not yet created are always not equal, similar to comparing null.TryRemove(K key, out V value)andbool TryRemove(KeyValuePair<K,V> item)forIAsyncCacheandAtomicFactoryAsyncCache.IAsyncCachedefault implementations for backwards compatibility throwNotSupportedException. There is no way to correctly implement either new method, so it is better to throw than give the caller an incorrect result. This would only apply if a caller implementsIAsyncCachethemselves, upgrades the library, and doesn't have impls for these methods.