Skip to content

Remove CachePolicy TryTrimExpired #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 18, 2023
Merged

Remove CachePolicy TryTrimExpired #499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f5e95d
rem
Nov 18, 2023
2faa5a6
Merge branch 'main' into users/alexpeck/removetrytrim
bitfaster Nov 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 0 additions & 35 deletions BitFaster.Caching.UnitTests/CachePolicyTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,40 +19,5 @@ public void WhenCtorFieldsAreAssigned()
cp.ExpireAfterAccess.HasValue.Should().BeFalse();
cp.ExpireAfter.HasValue.Should().BeFalse();
}

[Fact]
public void TryTrimWhenTrimNotSupportedReturnsFalse()
{
var cp = new CachePolicy(Optional<IBoundedPolicy>.None(), Optional<ITimePolicy>.None());

cp.TryTrimExpired().Should().BeFalse();
}

[Fact]
public void TryTrimWhenExpireAfterWriteReturnsTrue()
{
var expire = new Mock<ITimePolicy>();
var cp = new CachePolicy(Optional<IBoundedPolicy>.None(), new Optional<ITimePolicy>(expire.Object));

cp.TryTrimExpired().Should().BeTrue();
}

[Fact]
public void TryTrimWhenExpireAfterAccessReturnsTrue()
{
var expire = new Mock<ITimePolicy>();
var cp = new CachePolicy(Optional<IBoundedPolicy>.None(), Optional<ITimePolicy>.None(), new Optional<ITimePolicy>(expire.Object), Optional<IDiscreteTimePolicy>.None());

cp.TryTrimExpired().Should().BeTrue();
}

[Fact]
public void TryTrimWhenExpireAfterReturnsTrue()
{
var expire = new Mock<IDiscreteTimePolicy>();
var cp = new CachePolicy(Optional<IBoundedPolicy>.None(), Optional<ITimePolicy>.None(), Optional<ITimePolicy>.None(), new Optional<IDiscreteTimePolicy>(expire.Object));

cp.TryTrimExpired().Should().BeTrue();
}
}
}
27 changes: 0 additions & 27 deletions BitFaster.Caching/CachePolicy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,32 +55,5 @@ public CachePolicy(Optional<IBoundedPolicy> eviction, Optional<ITimePolicy> expi
/// a time to expire computed from the key and value.
/// </summary>
public Optional<IDiscreteTimePolicy> ExpireAfter { get; }

/// <summary>
/// If supported, trim expired items from the cache.
/// </summary>
/// <returns>True if expiry is supported and expired items were trimmed, otherwise false.</returns>
public bool TryTrimExpired()
{
if (ExpireAfterWrite.HasValue)
{
ExpireAfterWrite.Value.TrimExpired();
return true;
}

if (ExpireAfterAccess.HasValue)
{
ExpireAfterAccess.Value.TrimExpired();
return true;
}

if (ExpireAfter.HasValue)
{
ExpireAfter.Value.TrimExpired();
return true;
}

return false;
}
}
}