optimize Pipe.Wait #187
Merged
optimize Pipe.Wait #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use io.Copy with io.Discard instead of io.ReadAll to avoid allocating a buffer just to throw it away
|
Great! Thanks @toffaletti, much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use io.Copy with io.Discard instead of io.ReadAll to avoid allocating a buffer just to throw it away
see io.Copy and io.Discard implementation:
https://cs.opensource.google/go/go/+/refs/tags/go1.21.0:src/io/io.go;l=408;drc=1ff89009f198ad5bae3549dd3b992882bd97e5f8
https://cs.opensource.google/go/go/+/refs/tags/go1.21.0:src/io/io.go;drc=1ff89009f198ad5bae3549dd3b992882bd97e5f8;l=635
vs io.ReadAll:
https://cs.opensource.google/go/go/+/refs/tags/go1.21.0:src/io/io.go;l=701;drc=1ff89009f198ad5bae3549dd3b992882bd97e5f8