Throw instead of ignore, if headers are invalid#20
Closed
emmenko wants to merge 3 commits intonode-fetch:masterfrom
Closed
Throw instead of ignore, if headers are invalid#20emmenko wants to merge 3 commits intonode-fetch:masterfrom
emmenko wants to merge 3 commits intonode-fetch:masterfrom
Conversation
Collaborator
|
I would like to see how browsers and github polyfill handles it before making changes. I would like to avoid throwing errors if possible, especially on value like |
Collaborator
|
I have pushed a version 1.2.1 to normalize |
Author
|
@bitinn perfect, that would do it as well! Thanks 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After spending on hour trying to debug the problem, I found out that I was passing a number as header value, thus the header was ignored.
I think it would be much more useful throwing an error if something is not valid, instead of silently ignore it.
Thanks