avoid callback uncaught error #532
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the headers.set method could cause the Uncaught TypeError via the validation on headers, however this is not captured inside the event callback, which causes the exit of the whole application.
replicate:
got:
I thought about the testing, however it's not trivial to set up the test to return the invalid url, since the node.js serverResponse wouldn't allow invalid head name/value, I can capture a record(via nockBack), but that's kind of overkill maybe?
Thanks.