Refactor & robust terminal restore #1
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors most of the smaller functions.
The most significant refactoring changes include:
let-elseto reduce nesting.context()/.with_context()to add context to anyhow's errorsAdditionally, the main app loop got extracted from
maininto therun_appfunction.The reason for this is to ensure that the terminal is always getting restored properly,
even if the app returns an error.
I'm very tempted to also split up some of the larger functions and move some stuff into new modules, but last time I tried that I ended up with nasty merge conflicts 🥲.