Skip to content

Fix jobs without metrics #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joaquingx merged 1 commit into from
Dec 3, 2025
Merged

Fix jobs without metrics #268

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
85 changes: 57 additions & 28 deletions estela-web/src/components/JobMetrics/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,44 +221,73 @@ export function JobMetrics({ projectId, spiderId, jobId, jobStatus }: JobMetrics
}

if (!statsData) {
// If job is running, show a message indicating metrics will be available when job completes
if (jobStatus === "RUNNING" || jobStatus === "IN_QUEUE" || jobStatus === "WAITING") {
return (
<Content className="space-y-4 mt-8">
{/* Metrics Header */}
<Row justify="space-between" align="middle" className="mb-6">
<Col>
<Text className="text-estela-black-medium font-medium text-xl">Job Metrics</Text>
</Col>
</Row>
<Content className="text-center py-12">
<div className="space-y-4">
<div className="w-16 h-16 bg-blue-100 rounded-full flex items-center justify-center mx-auto">
<span className="text-2xl">📊</span>
</div>
<div>
<Text className="text-lg font-medium text-estela-black-full block">
Metrics will be available when the job completes
</Text>
<Text className="text-sm text-estela-black-medium">Current status: {jobStatus}</Text>
</div>
const isJobRunning = jobStatus === "RUNNING" || jobStatus === "IN_QUEUE" || jobStatus === "WAITING";

return (
<Content className="space-y-4 mt-8">
<Row justify="space-between" align="middle" className="mb-6">
<Col>
<Text className="text-estela-black-medium font-medium text-xl">Job Metrics</Text>
</Col>
</Row>
<Content className="text-center py-12">
<div className="space-y-4">
<div
className={`w-16 h-16 ${
isJobRunning ? "bg-blue-100" : "bg-gray-100"
} rounded-full flex items-center justify-center mx-auto`}
>
<span className="text-2xl">📊</span>
</div>
<div>
<Text className="text-lg font-medium text-estela-black-full block">
{isJobRunning ? "Waiting for metrics data..." : "No metrics data available"}
</Text>
<Text className="text-sm text-estela-black-medium">
{isJobRunning
? `Current status: ${jobStatus}`
: "No statistics were recorded for this job."}
</Text>
</div>
</Content>
</div>
</Content>
);
}
</Content>
);
}

// For completed jobs without stats data
const metricsExtensionEnabled = statsData["advanced_metrics/items_duplicates"] !== undefined;
const metricsDataReady = statsData["success_rate"] !== undefined;

if (!metricsDataReady) {
return (
<Content className="space-y-4 mt-8">
{/* Metrics Header */}
<Row justify="space-between" align="middle" className="mb-6">
<Col>
<Text className="text-estela-black-medium font-medium text-xl">Job Metrics</Text>
</Col>
</Row>
<Content className="text-center py-8">
<Text className="text-estela-black-medium">No metrics data available</Text>
<Content className="text-center py-12">
<div className="space-y-4">
<div
className={`w-16 h-16 ${
metricsExtensionEnabled ? "bg-blue-100" : "bg-gray-100"
} rounded-full flex items-center justify-center mx-auto`}
>
<span className="text-2xl">📊</span>
</div>
<div>
<Text className="text-lg font-medium text-estela-black-full block">
{metricsExtensionEnabled
? "Metrics will be available when the job completes"
: "Metrics not available for this job"}
</Text>
<Text className="text-sm text-estela-black-medium">
{metricsExtensionEnabled
? `Current status: ${jobStatus}`
: "This job was run without the metrics extension enabled."}
</Text>
</div>
</div>
</Content>
</Content>
);
Expand Down
Loading