Skip to content

Fix ECS apex redirects #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 20, 2025
Merged

Fix ECS apex redirects #106

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d5cc8a5
fix-ecs-apex-redirect
LeoDiazL Nov 20, 2025
dceb071
rollback alb lb
LeoDiazL Nov 20, 2025
cd389af
bumping conditionals
LeoDiazL Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 52 additions & 10 deletions operations/deployment/terraform/modules/aws/ecs/aws_ecs_networking.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ resource "aws_alb_target_group" "lb_targets" {
target_type = "ip"

lifecycle {
replace_triggered_by = [aws_security_group.ecs_sg]
replace_triggered_by = [aws_security_group.ecs_sg.id]
}
}

Expand Down Expand Up @@ -145,7 +145,7 @@ resource "aws_alb_listener" "http_redirect" {
}

resource "aws_alb_listener" "http_forward" {
count = var.aws_ecs_lb_redirect_enable && !contains(local.aws_ecs_lb_port,80) && !var.aws_certificate_enabled ? 1 : 0
count = var.aws_ecs_lb_redirect_enable && !contains(local.aws_ecs_lb_port,80) && !var.aws_certificate_enabled && !var.aws_ecs_lb_www_to_apex_redirect ? 1 : 0
load_balancer_arn = aws_alb.ecs_lb[0].id
port = "80"
protocol = "HTTP"
Expand All @@ -161,7 +161,7 @@ resource "aws_alb_listener" "http_forward" {
}

resource "aws_security_group_rule" "incoming_alb_http" {
count = length(aws_alb_listener.http_redirect)
count = length(aws_alb_listener.http_redirect) + length(aws_alb_listener.http_forward) + length(aws_alb_listener.http_www_redirect)
type = "ingress"
from_port = 80
to_port = 80
Expand All @@ -174,11 +174,11 @@ resource "aws_alb_listener" "https_redirect" {
count = var.aws_ecs_lb_redirect_enable && !contains(local.aws_ecs_lb_port,443) && var.aws_certificate_enabled ? 1 : 0
#count = var.aws_ecs_lb_redirect_enable && !contains(local.aws_ecs_lb_port,443) ? var.aws_certificates_selected_arn != "" ? 1 : 0 : 0
#count = var.aws_ecs_lb_redirect_enable && var.aws_certificates_selected_arn != "" && !contains(local.aws_ecs_lb_port,443) ? 1 : 0
load_balancer_arn = "${aws_alb.ecs_lb[0].id}"
load_balancer_arn = aws_alb.ecs_lb[0].id
port = "443"
protocol = "HTTPS"
certificate_arn = var.aws_certificates_selected_arn
ssl_policy = var.aws_certificates_selected_arn != "" ? "ELBSecurityPolicy-TLS13-1-2-2021-06" : "" # https://docs.aws.amazon.com/elasticloadbalancing/latest/application/create-https-listener.html
ssl_policy = var.aws_certificates_selected_arn != "" ? var.aws_ecs_lb_ssl_policy : "" # https://docs.aws.amazon.com/elasticloadbalancing/latest/application/create-https-listener.html

default_action {
target_group_arn = aws_alb_target_group.lb_targets[0].id
Expand All @@ -188,8 +188,12 @@ resource "aws_alb_listener" "https_redirect" {

resource "aws_alb_listener_rule" "redirect_based_on_path_for_http" {
for_each = { for idx, path in local.aws_ecs_lb_container_path_redirect : idx => path if length(path) > 0 }
listener_arn = var.aws_certificates_selected_arn != "" ? aws_alb_listener.https_redirect[0].arn : aws_alb_listener.http_redirect[0].arn

#listener_arn = var.aws_certificates_selected_arn != "" ? aws_alb_listener.https_redirect[0].arn : aws_alb_listener.http_redirect[0].arn
listener_arn = var.aws_certificate_enabled ? aws_alb_listener.https_redirect[0].arn : (
length(aws_alb_listener.http_redirect) > 0 ? aws_alb_listener.http_redirect[0].arn : (
length(aws_alb_listener.http_forward) > 0 ? aws_alb_listener.http_forward[0].arn : aws_alb_listener.http_www_redirect[0].arn
)
)
action {
type = "forward"
target_group_arn = aws_alb_target_group.lb_targets[each.key + 1].arn
Expand All @@ -202,9 +206,47 @@ resource "aws_alb_listener_rule" "redirect_based_on_path_for_http" {
}
}

resource "aws_alb_listener" "http_www_redirect" {
count = var.aws_ecs_lb_redirect_enable && !contains(local.aws_ecs_lb_port,80) && !var.aws_certificate_enabled && var.aws_ecs_lb_www_to_apex_redirect ? 1 : 0
load_balancer_arn = aws_alb.ecs_lb[0].id
port = "80"
protocol = "HTTP"

default_action {
type = "fixed-response"

fixed_response {
content_type = "text/plain"
message_body = "Not Found"
status_code = "404"
}
}
depends_on = [
aws_alb.ecs_lb,
aws_alb_target_group.lb_targets
]
}

resource "aws_lb_listener_rule" "http_forward_apex" {
count = var.aws_ecs_lb_www_to_apex_redirect && var.aws_r53_domain_name != "" && !var.aws_certificate_enabled && length(aws_alb_listener.http_www_redirect) > 0 ? 1 : 0
listener_arn = aws_alb_listener.http_www_redirect[0].arn
priority = 20

condition {
host_header {
values = [var.aws_r53_domain_name]
}
}

action {
type = "forward"
target_group_arn = aws_alb_target_group.lb_targets[0].id
}
}

resource "aws_lb_listener_rule" "redirect_www_to_apex" {
count = var.aws_ecs_lb_www_to_apex_redirect && var.aws_r53_domain_name != "" ? 1 : 0
listener_arn = var.aws_certificate_enabled ? aws_alb_listener.lb_listener_ssl[0].arn : aws_alb_listener.lb_listener[0].arn
count = var.aws_ecs_lb_www_to_apex_redirect && var.aws_r53_domain_name != "" && (var.aws_certificate_enabled ? length(aws_alb_listener.https_redirect) > 0 : length(aws_alb_listener.http_www_redirect) > 0) ? 1 : 0
listener_arn = var.aws_certificate_enabled ? aws_alb_listener.https_redirect[0].arn : aws_alb_listener.http_www_redirect[0].arn
priority = 10

condition {
Expand All @@ -220,7 +262,7 @@ resource "aws_lb_listener_rule" "redirect_www_to_apex" {
port = var.aws_certificate_enabled ? "443" : "80"
protocol = var.aws_certificate_enabled ? "HTTPS" : "HTTP"
status_code = "HTTP_301"
host = "${var.aws_r53_domain_name}"
host = var.aws_r53_domain_name
path = "/#{path}"
query = "#{query}"
}
Expand Down