-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use bitcore-lib as a peerDependency #27
Open
CaptEmulation
wants to merge
3
commits into
bitpay:master
Choose a base branch
from
CaptEmulation:bitcore-lib-as-peer-depdency
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Use bitcore-lib as a peerDependency #27
CaptEmulation
wants to merge
3
commits into
bitpay:master
from
CaptEmulation:bitcore-lib-as-peer-depdency
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 25, 2017
well from a Travis CI perspective I certainly see the flaw in my plan |
CaptEmulation
force-pushed
the
bitcore-lib-as-peer-depdency
branch
from
March 25, 2017 22:51
c367194
to
b2347d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One wrinkle to using the bitcore stack is the obvious need to have a singleton
bitcore-lib
. Thebitcoin-lib
package hosts thebitcoind
library and there are good reasons to not wanting to have multiplebitcoind
instances running on the same machine.However, I am not a fan of the runtime check and would rather have all packages be declaring
bitcoin-lib
inpeerDependencies
. This way the enclosing package can specify whatever version ofbitcoin-lib
it wants andnpm
will inform user if there is an unmet dependency at install time rather than run time.I have a working example of
bitcore-lib
running as a peerDependency at bitcore-docker-build which is also running testnet at bitcore.soapbubble.online/insightI also updated
bitcore-lib
to 0.14 becausebitcore-wallet-service
has already done so and I figured if it was good enough forbitcoin-wallet-service
it's good enough for everything else 😄