Skip to content
This repository has been archived by the owner on Apr 3, 2019. It is now read-only.

Use bitcore-lib as a peerDependency #639

Conversation

CaptEmulation
Copy link

@CaptEmulation CaptEmulation commented Mar 25, 2017

One wrinkle to using the bitcore stack is the obvious need to have a singleton bitcore-lib. The bitcoin-lib package hosts the bitcoind library and there are good reasons to not wanting to have multiple bitcoind instances running on the same machine.

However, I am not a fan of the runtime check and would rather have all packages be declaring bitcoin-lib in peerDependencies. This way the enclosing package can specify whatever version of bitcoin-lib it wants and npm will inform user if there is an unmet dependency at install time rather than run time.

I have a working example of bitcore-lib running as a peerDependency at bitcore-docker-build which is also running testnet at bitcore.soapbubble.online/insight
:

@coveralls
Copy link

Coverage Status

Coverage remained the same at 83.189% when pulling 38bb8f2 on CaptEmulation:bitcore-lib-as-peer-dependency into 4f7ddac on bitpay:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 83.189% when pulling 3374096 on CaptEmulation:bitcore-lib-as-peer-dependency into 4f7ddac on bitpay:master.

@matiu
Copy link
Collaborator

matiu commented Feb 9, 2018

I think this is not longer needed in current npm. thanks!

@matiu matiu closed this Feb 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants