-
Notifications
You must be signed in to change notification settings - Fork 646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use bitcore-lib as a peerDependency #500
base: master
Are you sure you want to change the base?
Use bitcore-lib as a peerDependency #500
Conversation
5eb2dac
to
ffef84a
Compare
re: the travis failures on node v0.10.25 which runs with npm 1.x. Can reproduce locally. They do not occur for me locally on v0.10.48 which runs with npm 2.x. So it appears that |
So are
|
One wrinkle to using the bitcore stack is the obvious need to have a singleton
bitcore-lib
. Thebitcoin-lib
package hosts thebitcoind
library and there are good reasons to not wanting to have multiplebitcoind
instances running on the same machine.However, I am not a fan of the runtime check and would rather have all packages be declaring
bitcoin-lib
inpeerDependencies
. This way the enclosing package can specify whatever version ofbitcoin-lib
it wants andnpm
will inform user if there is an unmet dependency at install time rather than run time.I have a working example of
bitcore-lib
running as a peerDependency at bitcore-docker-build which is also running testnet at bitcore.soapbubble.online/insightI also updated
bitcore-lib
to 0.14 becausebitcore-wallet-service
has already done so and I figured if it was good enough forbitcoin-wallet-service
it's good enough for everything else 😄