Mysql 8 dev #602
Closed
Mysql 8 dev #602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
AMecea
reviewed
Sep 16, 2020
| RUN apt-get update \ | ||
| && apt-get install -y --no-install-recommends \ | ||
| percona-toolkit percona-xtrabackup-24 unzip \ | ||
| percona-toolkit percona-xtrabackup-80 unzip \ |
Contributor
There was a problem hiding this comment.
Same thing should be done for the root Dockerfile.sidecar
| // CSV engine for this table can't be used because we use REPLACE statement that requires PRIMARY KEY or | ||
| // UNIQUE KEY index | ||
| // nolint: gosec | ||
| if !strings.HasSuffix(cfg.Hostname, "-0") { |
Contributor
There was a problem hiding this comment.
This requires some comments explaining why this is needed. I'm curious why this works? 😄
Also, there is a function that checks the pod ordinal:
Suggested change
| if !strings.HasSuffix(cfg.Hostname, "-0") { | |
| if !cfg.IsFirstPodInSet() { |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #363
The "sys_operator.status" table of the slave node does not appear to be clean, although --tables-exclude is added to the backup. Delete "sys_operator.status" before starting from the slave node, and it's working fine now.