Limit backup job name to 63 chars, fix #836 #837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w33dw0r7d
changed the title
w33dw0r7d
force-pushed
the
limit-backup-job-name
branch
from
c98ca0e to
54910b8
Compare
Contributor
Author
|
@cndoit18 review please. |
cndoit18
reviewed
Aug 10, 2022
Collaborator
cndoit18
left a comment
cndoit18
left a comment
There was a problem hiding this comment.
Thank you very much for your contribution, add some unit tests, plz.
w33dw0r7d
force-pushed
the
limit-backup-job-name
branch
from
54910b8 to
678260c
Compare
Contributor
Author
|
@cndoit18 Thank you for review. Add tests. |
Contributor
Author
|
@cndoit18 review please. |
cndoit18
approved these changes
Aug 16, 2022
Contributor
Author
|
@cndoit18 Merge please. |
Collaborator
|
Hi, squash your commits, plz |
w33dw0r7d
force-pushed
the
limit-backup-job-name
branch
from
c494268 to
8294735
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes/fixes #836