Skip to content

Commit 4ba3da1

Browse files
committed
Fix a memory leak in sr_ioctl_createraid().
Found while reading the code. OK marco@ oga@.
1 parent 2cc1fda commit 4ba3da1

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

sys/dev/softraid.c

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3267,7 +3267,7 @@ sr_ioctl_createraid(struct sr_softc *sc, struct bioc_createraid *bc,
32673267
struct scsi_link *link;
32683268
struct device *dev;
32693269
char *uuid, devname[32];
3270-
dev_t *dt;
3270+
dev_t *dt = NULL;
32713271
int i, no_chunk, rv = EINVAL, target, vol;
32723272
int no_meta;
32733273

@@ -3536,6 +3536,8 @@ sr_ioctl_createraid(struct sr_softc *sc, struct bioc_createraid *bc,
35363536

35373537
sd->sd_ready = 1;
35383538

3539+
free(dt, M_DEVBUF, bc->bc_dev_list_len);
3540+
35393541
return (rv);
35403542

35413543
unwind:
@@ -3544,6 +3546,8 @@ sr_ioctl_createraid(struct sr_softc *sc, struct bioc_createraid *bc,
35443546
if (rv == EAGAIN)
35453547
rv = 0;
35463548

3549+
free(dt, M_DEVBUF, bc->bc_dev_list_len);
3550+
35473551
return (rv);
35483552
}
35493553

0 commit comments

Comments
 (0)