Fix tautological comparison in dsdt code.

bluerise · bluerise · commit e7d832b62677 · 2015-02-09T11:02:05.000+01:00
The pnpid member is a char[20] array in a struct. It's the second
member of that struct. Comparing the pointer of pnpid is always
not NULL.
diff --git a/sys/dev/acpi/dsdt.c b/sys/dev/acpi/dsdt.c
@@ -581,7 +581,7 @@ aml_notify_dev(const char *pnpid, int notify_value)
 		return;
 
 	SLIST_FOREACH(pdata, &aml_notify_list, link)
-		if (pdata->pnpid && !strcmp(pdata->pnpid, pnpid))
+		if (!strcmp(pdata->pnpid, pnpid))
 			pdata->cbproc(pdata->node, notify_value, pdata->cbarg);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -581,7 +581,7 @@ aml_notify_dev(const char *pnpid, int notify_value)`
`581`	`581`	`return;`
`582`	`582`
`583`	`583`	`SLIST_FOREACH(pdata, &aml_notify_list, link)`
`584`		`- if (pdata->pnpid && !strcmp(pdata->pnpid, pnpid))`
	`584`	`+ if (!strcmp(pdata->pnpid, pnpid))`
`585`	`585`	`pdata->cbproc(pdata->node, notify_value, pdata->cbarg);`
`586`	`586`	`}`
`587`	`587`