Feature/automation upload #102

lpusok · 2019-05-23T16:06:23Z

No description provided.

- uplading succesfully, if cli params are given.

…f artifacts

…es; renaming ExportCodesignFiles to CollectCodesignFiles

bitriseio/bitriseio.go

cmd/scan.go

codesign/export.go

…cified for automatic upload

godrei · 2019-05-29T09:12:29Z

cmd/xcode.go

 	xcodeCmd.Flags().StringVar(&paramXcodeScheme, "scheme", "", "Xcode Scheme")
 	xcodeCmd.Flags().StringVar(&paramXcodebuildSDK, "xcodebuild-sdk", "", "xcodebuild -sdk param. If a value is specified for this flag it'll be passed to xcodebuild as the value of the -sdk flag. For more info about the values please see xcodebuild's -sdk flag docs. Example value: iphoneos")
+	// Flags used to automatically upload artifacts
+	xcodeCmd.Flags().BoolVar(&isWriteFiles, "write-files", true, "Set wether to export artifacts to a local directory.")


pls also add this to the xamarin and uitest scanner, may these could be root level flags

godrei · 2019-05-29T09:15:35Z

cmd/xcode.go

 	xcodeCmd.Flags().StringVar(&paramXcodebuildSDK, "xcodebuild-sdk", "", "xcodebuild -sdk param. If a value is specified for this flag it'll be passed to xcodebuild as the value of the -sdk flag. For more info about the values please see xcodebuild's -sdk flag docs. Example value: iphoneos")
+	// Flags used to automatically upload artifacts
+	xcodeCmd.Flags().BoolVar(&isWriteFiles, "write-files", true, "Set wether to export artifacts to a local directory.")
+	xcodeCmd.Flags().StringVar(&personalAccessToken, "auth-token", "", "Personal access token. In case app-slug parameter is also provided, will automatically upload artifacts to bitrise.io.")


i would mention that these flags are working only together:

Personal access token. Requires app-slug flag to be defined as well and will cause the codesigning file to be uploaded automatically

godrei · 2019-05-29T09:16:31Z

cmd/xcode.go

-	absExportOutputDirPath, err := initExportOutputDir()
-	if err != nil {
-		return fmt.Errorf("failed to prepare Export directory: %s", err)
+	absExportOutputDirPath := ""


NOTE: var absExportOutputDirPath string, would explicitly show that we do not care / use the default value of the var

godrei · 2019-05-29T09:19:44Z

cmd/xcode.go

+	if err != nil {
+		return err
+	}
+	certsUploaded, provProfilesUploaded, err := codesign.UploadAndWriteCodesignFiles(certificatesToExport,


pls leave a comment that certificatesOnly will lead to 0 elements certsUploaded, that's why no need to pass it further

codesign/export.go

godrei · 2019-05-29T09:25:48Z

gows.yml

@@ -1 +1 @@
-package_name: github.com/bitrise-tools/codesigndoc
+package_name: github.com/bitrise-io/codesigndoc


could be removed as we do not use gows this days

godrei

pls have a look at my notes

lszucs

Minor comments, looks good otherwise.

lszucs · 2019-05-29T11:25:06Z

bitriseio/bitrise/profile.go

 // UploadProvisioningProfile ...
-func (client *Client) UploadProvisioningProfile(uploadURL string, uploadFileName string, outputDirPath string, exportFileName string) error {
-	log.Printf("Upload %s to Bitrise...", exportFileName)
+func (client *Client) UploadProvisioningProfile(uploadURL string, uploadFileName string, content io.Reader) error {


Same comment and previously: uploadFileName is used only in the logging statement.

lszucs · 2019-05-29T11:25:48Z

bitriseio/bitrise/certificate.go

 // UploadIdentity ...
-func (client *Client) UploadIdentity(uploadURL string, uploadFileName string, outputDirPath string, exportFileName string) error {
+func (client *Client) UploadIdentity(uploadURL string, uploadFileName string, exportFileName string, content io.Reader) error {
 	log.Printf("Upload %s to Bitrise...", exportFileName)


exportFileName is used only in the log statement, however, the logging could be done on the caller side.

In that case, the parameter is not needed and the function is cleaner in terms of the log output it produces

…sts and Xamarin

…ameters

lszucs

Seems good to me, although I am not a subject matter expert.

…sabled

cmd/scan.go

cmd/xamarin.go

cmd/scan.go

godrei

pls have a look at my notes

…t to fallback

lpusok added 21 commits May 21, 2019 13:47

Adding new authToken CLI param

9d7daee

Exporting artifacts as io.Reader instead of file

39419dc

Migrate org/package names from bitrise-tools to bitrise-io

00f830a

Added new functions to return certificates and profiles.

6b1c305

Phase 1 complete, new flags wired in

2b7d53c

Phase 2

5cb9d02

- uplading succesfully, if cli params are given.

Use common upload code for both automatic and user initiated upload o…

fc45bd8

…f artifacts

Renaming Certifificates and ProvisioningProfile fields

7055f4e

Seperate upload and artifact write into UploadAndWriteCodesignFiles

93e46a4

Separate UploadAndWriteCodesignFiles: moving out of ExportCodesignfil…

ef99ade

…es; renaming ExportCodesignFiles to CollectCodesignFiles

Moving UploadAndWriteCodesignFiles() to codesign package, for reuse

5cd80f6

Use codesign.UploadAndWriteCodesignFiles in codesigndocuitest package

c813f73

Removing now renamed unused functions

eed7714

Unexporting esport functions

caf15d4

Renaming and removing unused functions in bitriseio

89f7cb9

Adding missing files

82b0ee4

Migrating bitrise-init to bitrise-io org

984f608

Removing unused functions

8b61bcb

Using new GetAppList in bitrise.client

ab1971c

Removing unused function

951c6e4

removing unused function

636890a

godrei reviewed May 28, 2019

View reviewed changes

bitriseio/bitriseio.go Show resolved Hide resolved

godrei reviewed May 28, 2019

View reviewed changes

cmd/scan.go Show resolved Hide resolved

godrei reviewed May 28, 2019

View reviewed changes

codesign/export.go Outdated Show resolved Hide resolved

Print a warning if not both app slug and personal access token is sep…

0eb4966

…cified for automatic upload

godrei reviewed May 29, 2019

View reviewed changes

codesign/export.go Outdated Show resolved Hide resolved

godrei reviewed May 29, 2019

View reviewed changes

codesign/export.go Outdated Show resolved Hide resolved

godrei reviewed May 29, 2019

View reviewed changes

godrei requested changes May 29, 2019

View reviewed changes

lszucs reviewed May 29, 2019

View reviewed changes

lpusok added 6 commits May 29, 2019 13:48

Move automatic codesign file upload to the scan command level

979843d

Print last lines of build log in case of error.

cb1349d

Do not create export dir if write-files flag is false for Xcode UI te…

9139e86

…sts and Xamarin

removing gows.yml as it is unused

03dfb5e

Fixing scan command flags, revise failed build logging

4ead5d4

Simplifiing file upload, omit file name if not needed in function par…

53e5022

…ameters

lszucs previously approved these changes May 29, 2019

View reviewed changes

Updating file write handling, now have 3 options always, fallback, di…

53c83c8

…sabled

lpusok dismissed lszucs’s stale review via 53c83c8 May 30, 2019 14:22

lpusok added 6 commits May 30, 2019 16:25

Typo fix

9dd01fc

Fixing output dir creation

7b54028

Fixing UploadAndWriteCodesignFiles error handling

d5d1f24

Restoring logic to open saved files folder after uplopading

f8d2871

Removing duplicated log line

32425b3

Removing redundant http upload functions

a064848

godrei reviewed May 31, 2019

View reviewed changes

cmd/scan.go Outdated Show resolved Hide resolved

godrei reviewed May 31, 2019

View reviewed changes

cmd/xamarin.go Show resolved Hide resolved

godrei reviewed May 31, 2019

View reviewed changes

cmd/scan.go Show resolved Hide resolved

godrei requested changes May 31, 2019

View reviewed changes

lpusok added 3 commits May 31, 2019 16:05

Update CLI help, write log files on failure if write-files flag is se…

85f5627

…t to fallback

dep update

3150f1d

Remove empty line in imports

364b302

godrei approved these changes Jun 3, 2019

View reviewed changes

lpusok merged commit d0d7a94 into master Jun 3, 2019

lpusok deleted the feature/automation-upload branch June 3, 2019 13:48

		@@ -1 +1 @@
		package_name: github.com/bitrise-tools/codesigndoc
		package_name: github.com/bitrise-io/codesigndoc

Feature/automation upload #102

Feature/automation upload #102

Uh oh!

Conversation

lpusok commented May 23, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

godrei May 29, 2019

Choose a reason for hiding this comment

Uh oh!

godrei May 29, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

godrei May 29, 2019

Choose a reason for hiding this comment

Uh oh!

godrei May 29, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

godrei May 29, 2019

Choose a reason for hiding this comment

Uh oh!

godrei left a comment

Choose a reason for hiding this comment

Uh oh!

lszucs left a comment

Choose a reason for hiding this comment

Uh oh!

lszucs May 29, 2019

Choose a reason for hiding this comment

Uh oh!

lszucs May 29, 2019

Choose a reason for hiding this comment

Uh oh!

lszucs left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

godrei left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

godrei May 29, 2019 •

edited

Loading