Add xcodebuild command destination flag
#147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godrei
reviewed
Jan 27, 2022
godrei
reviewed
Jan 28, 2022
| } | ||
|
|
||
| // OpenArchivableProject ... | ||
| func OpenArchivableProject(pth, schemeName, configurationName string) (*xcodeproj.XcodeProj, *xcscheme.Scheme, string, error) { |
Contributor
There was a problem hiding this comment.
you do not need a separate OpenArchivableProject and OpenArchivableWorkspace.
schemeint.Scheme accepts both a workspace and project path, whatever is provided, it figures out the correct root project (which is connected to the scheme).
The issue with the current implementation is at the OpenArchivableWorkspace: In the case of a workspace project, a given scheme can be located both under the .xcworkspace or under one of the included .xcproject files, this is handled correctly by the schemeint.Scheme, but OpenArchivableWorkspace is not aware of the schemes under the .xcworkspace.
shams-ahmed
changed the title
destination flag
godrei
approved these changes
Jan 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without a
destinationflag xcodebuild fails when running on M1 machine since it always had the mac device.Only affects Apple project for scan and uitest command
fixes #144 and #131
Resolves issues with M1 as well as adds additional options for -sdk and -destination :
-sdk: If a value is specified for this flag it'll be passed to xcodebuild as the value of the -sdk flag. For more info about the values please see xcodebuild's -sdk flag docs. Example value: iphoneos")
-destination: The xcodebuild -destination option takes as its argument a destination specifier describing the device (or devices) to use as a destination i.e generic/platform=iOS.
See release notes for instructions. Some M1 machines do not have certain folders so you may need to use a custom folder to run curl script