-
Notifications
You must be signed in to change notification settings - Fork 37
Project scan xcode project for xcodeuitests #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ck in to a separated func;
…n to a separated func;
…o; add the auto scan function to the xcodeUITests as well
godrei
reviewed
Feb 15, 2019
godrei
requested changes
Feb 15, 2019
Contributor
godrei
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls have a look at my note
godrei
approved these changes
Feb 15, 2019
trapacska
suggested changes
Feb 15, 2019
trapacska
approved these changes
Feb 15, 2019
lpusok
reviewed
Feb 15, 2019
Contributor
lpusok
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decription:
Add the automatic scan feature to the codesigndoc.
The tool should check the root directory for the project files (e.g: .xcodeproj or .xcworkspace). If it've found one it should scan that. If it could not find any, then it should rollback to the current 'drag-and-drop' solution.