Step 1212 pathutil #141
Merged
Step 1212 pathutil #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bence1001
suggested changes
Sep 1, 2021
Bence1001
approved these changes
Sep 1, 2021
mateherber
pushed a commit
that referenced
this pull request
Dec 9, 2021
* Regroup pathutil functions. * Group functions in pathutil.go. * Introduce PathProvider and PathModifier. * Fix lint issue. * Regenerate pathutil mocks. * Introduce PathChecker. * Add IsPathExists to PathChecker interface. * Use default prefix for implementation structs. * Rename TempDir to CreateTempDir. * Regenerate pathutil mocks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR introduces
PathProvider,PathCheckerandPathModifierto support Xcode Test Step's ideal step refactor.Changes
PathModifierto break direct dependency to AbsPath functionPathCheckerto break direct dependency to IsPathExists functionNon-functional changes:
TempDirProvidertoPathProviderto support adding more related functions laterEscapeGlobPathfunction moved to pathutil.go to keep function related to file path modification in the same fileListEntriesfunction moved to path_filter.go as it provides path listing with FilterFuncListPathInDirSortedByComponentsfunction moved to sortable_path.go as it provides sorted path listingPath provider functions,Path checker functions,Path modifier functionsandChange dir functionsInvestigation details
Decisions