Skip to content

Improve exit code error checking utilizing go error unwrap functionality #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2022
Merged

Improve exit code error checking utilizing go error unwrap functionality #157

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions errorutil/errorutil.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,14 @@
package errorutil

import (
"errors"
"os/exec"
"regexp"
)

func exitCode(err error) int {
if exitError, ok := err.(*exec.ExitError); ok {
var exitError *exec.ExitError
if errors.As(err, &exitError) {
return exitError.ProcessState.ExitCode()
}
return -1
Expand All @@ -22,7 +24,7 @@ func IsExitStatusError(err error) bool {
func IsExitStatusErrorStr(errString string) bool {
// https://golang.org/src/os/exec_posix.go?s=2421:2459#L87
// example exit status error string: exit status 1
var rex = regexp.MustCompile(`^exit status [0-9]{1,3}$`)
var rex = regexp.MustCompile(`^exit status \d{1,3}$`)
return rex.MatchString(errString)
}

Expand Down