Skip to content

Remove CompareVersions logs #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 7, 2022
Merged

Remove CompareVersions logs #169

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7fa57b3
Remove CompareVersions logs
godrei Oct 7, 2022
389787b
Update versions/versions.go
godrei Oct 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions versions/versions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package versions

import (
"log"
"fmt"
"strconv"
"strings"
)
Expand Down Expand Up @@ -36,14 +36,12 @@ func CompareVersions(version1, version2 string) (int, error) {
for i, num := range version1Slice {
num1, err := strconv.ParseInt(num, 0, 64)
if err != nil {
log.Println("Failed to parse int:", err)
return -2, err
return -2, fmt.Errorf("failed to parse int (%s): %s", num, err)
}

num2, err2 := strconv.ParseInt(version2Slice[i], 0, 64)
if err2 != nil {
log.Println("Failed to parse int:", err2)
return -2, err
return -2, fmt.Errorf("failed to parse int (%s): %s", version2Slice[i], err2)
}

if num2 > num1 {
Expand Down