rsync output #178
Merged
rsync output #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
ofalvai
approved these changes
Jan 30, 2023
Contributor
ofalvai
left a comment
ofalvai
left a comment
There was a problem hiding this comment.
Looks good, but why didn't you modify the original RunCommand() method instead? That would solve all other possible logging issues, no?
Contributor
Author
|
@ofalvai this is the V1 command package, still in use by tools and probably by steps too and I wanted to reduce the blast radius. |
vshah23
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR stops rsync printing directly to the standard output.
This is needed because the Bitrise CLI uses
CopyFileandCopyDirfunctions for activating local Steps.When rsync fails, it directly prints an error to the stdout, which messes up the CLI's structured logging.