Add support for automatic signing style #248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godrei
commented
Oct 8, 2024
| codeSigningStyle SigningStyle, | ||
| xcodeMajorVersion int64, | ||
| ) (exportoptions.ExportOptions, error) { | ||
| mainTargetBundleID, entitlementsByBundleID, err := g.applicationTargetsAndEntitlements(exportMethod) |
Contributor
Author
There was a problem hiding this comment.
Code from the previous g.generateExportOptions moved here and the first part of the code is moved into the new applicationTargetsAndEntitlements.
godrei
commented
Oct 9, 2024
| @@ -0,0 +1,21 @@ | |||
| package exportoptionsgenerator | |||
Contributor
Author
There was a problem hiding this comment.
Moved here from exportoptionsgenerator/exportoptionsgenerator.go without any change.
godrei
commented
Oct 9, 2024
| @@ -0,0 +1,73 @@ | |||
| package exportoptionsgenerator | |||
Contributor
Author
There was a problem hiding this comment.
Moved here from exportoptionsgenerator/exportoptionsgenerator.go, the single change is adding GetDefaultProvisioningProfile to ProvisioningProfileProvider, previously this functionality was assigned to ExportOptionsGenerator.
godrei
commented
Oct 9, 2024
| @@ -0,0 +1,75 @@ | |||
| package exportoptionsgenerator | |||
Contributor
Author
There was a problem hiding this comment.
Moved here from exportoptionsgenerator/exportoptionsgenerator.go without any change.
tothszabi
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reorganizes the files in the
exportoptionsgeneratorpackage and adds support for the automatic signing style.The
exportoptionsgeneratorpackage new organisation:ExportOptionsGeneratordependencies are moved to their own files, to shorten the code inexportoptionsgenerator.goAutomatic signing style support:
provisioningProfilesentry shouldn't be in the exportOptions.plist when the IPA export is Xcode managed