Skip to content

Conversation

@lpusok
Copy link
Contributor

@lpusok lpusok commented Mar 26, 2025

Added CommandArgs function for the xcodebuild CommandBuilder, this removes the dependency on the v1 command package and helps with xcbeautify support integration.
The existing xcodecommand package only requires xcodebuild arguments, with this change we do no need:

xcodebuildCmdWithArgs := archiveCmd.ExecCommand().Args
if len(xcodebuildCmdWithArgs) == 0 {
  panic("")
}
onlyArgs = xcodebuildCmdWithArgs[1:]

only:

onlyArgs := archiveCmd.CommandArgs()

lpusok added 3 commits March 26, 2025 15:15
…moves the dependency on the v1 command package and helps with xcbeautify support integration.
}

func (c *CommandBuilder) cmdSlice() []string {
func (c CommandBuilder) cmdSlice() []string {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Goland will complain that some function defined on the regular and some on the pointer for the struct. Can you update the changed functions to also use the pointer version in the method signature here and in the ExportCommandModel struct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@lpusok lpusok merged commit 6b912cd into v1 Mar 26, 2025
3 checks passed
@lpusok lpusok deleted the STEP-2074-prepare-xcbeautify-support branch March 26, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants