Add new export methods #265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpusok
force-pushed
the
STEP-2072-new-export-methods
branch
from
690e109 to
8d73ab5
Compare
godrei
reviewed
Apr 7, 2025
exportoptions/appstore_options.go
Outdated
| // NewAppStoreOptions sets "app-store" as the export method | ||
| // deprecated: use NewAppStoreConnectOptions instead | ||
| func NewAppStoreOptions() AppStoreOptionsModel { | ||
| return AppStoreOptionsModel{ |
Contributor
There was a problem hiding this comment.
this could be NewAppStoreConnectOptions(MethodAppStore), right?
Contributor
Author
There was a problem hiding this comment.
Yes it is the same. It could be removed, but there is a few code using it: https://github.com/search?q=org%3Abitrise-steplib%20NewAppStoreOptions&type=code
Contributor
There was a problem hiding this comment.
Yeah, that make sense, I ment the function could return NewAppStoreConnectOptions(MethodAppStore), instead of creating a new AppStoreOptionsModel by hand.
ofalvai
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.