[ACI-4111] Add a log interceptor #283
Conversation
Singles out [Bitrise ...] logs from the rest and forwards them to stdout
SummaryThis PR adds a log interceptor that filters and routes log output based on regex patterns. It introduces a new PrefixInterceptor that can intercept writes matching a specific prefix pattern and forward them to multiple outputs. The implementation includes proper goroutine management and pipe-based communication for handling concurrent log processing. Walkthrough
|
Badlazzor
requested review from
a team,
bitrise-coresteps-bot,
krystiankrasacki and
zsolt-marta-bitrise
and removed request for
a team,
bitrise-coresteps-bot and
krystiankrasacki
bitrise-ip-bot
left a comment
bitrise-ip-bot
left a comment
There was a problem hiding this comment.
This is an AI-generated review. Please review it carefully.
Actionable comments posted: 2
bitrise-ip-bot
left a comment
bitrise-ip-bot
left a comment
There was a problem hiding this comment.
This is an AI-generated review. Please review it carefully.
Actionable comments posted: 1
bitrise-ip-bot
left a comment
bitrise-ip-bot
left a comment
There was a problem hiding this comment.
This is an AI-generated review. Please review it carefully.
Actionable comments posted: 3
Co-authored-by: bitrise-ip-bot <95076763+bitrise-ip-bot@users.noreply.github.com>
bitrise-ip-bot
left a comment
bitrise-ip-bot
left a comment
There was a problem hiding this comment.
This is an AI-generated review. Please review it carefully.
Actionable comments posted: 2
Co-authored-by: bitrise-ip-bot <95076763+bitrise-ip-bot@users.noreply.github.com>
bitrise-ip-bot
left a comment
bitrise-ip-bot
left a comment
There was a problem hiding this comment.
This is an AI-generated review. Please review it carefully.
Actionable comments posted: 3
bitrise-ip-bot
left a comment
bitrise-ip-bot
left a comment
There was a problem hiding this comment.
This is an AI-generated review. Please review it carefully.
Actionable comments posted: 1
xcpretty/xcpretty.go
Outdated
| interceptor := loginterceptor.NewPrefixInterceptor(re, os.Stdout, outWriter) | ||
| defer func() { | ||
| if err := interceptor.Close(); err != nil { | ||
| loggerV1.Warnf("Failed to close log interceptor, error: %s", err) |
There was a problem hiding this comment.
If we're using the go-utils log, can we use the same in the interceptor too?
bitrise-ip-bot
left a comment
bitrise-ip-bot
left a comment
There was a problem hiding this comment.
This is an AI-generated review. Please review it carefully.
Actionable comments posted: 1
bitrise-ip-bot
left a comment
bitrise-ip-bot
left a comment
There was a problem hiding this comment.
This is an AI-generated review. Please review it carefully.
Actionable comments posted: 1
Singles out [Bitrise ...] logs from the rest and forwards them to stdout