[ACI-4111] Use loginterceptor 2 #284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SummaryThis PR integrates loginterceptor functionality into xcbeautify and xcpretty command runners. However, it introduces a critical compilation bug where an undefined constant is referenced. Walkthrough
|
Contributor
bitrise-ip-bot
left a comment
bitrise-ip-bot
left a comment
There was a problem hiding this comment.
This is an AI-generated review. Please review it carefully.
Actionable comments posted: 1
| buildOutBuffer bytes.Buffer | ||
| pipeReader, pipeWriter = io.Pipe() | ||
| buildOutWriter = io.MultiWriter(&buildOutBuffer, pipeWriter) | ||
| prefixRegexp = regexp.MustCompile(prefix) |
Contributor
There was a problem hiding this comment.
🐛 Bug
The constant 'prefix' is not defined in this file, causing a compilation error. The constant is defined in xcpretty.go but not accessible here.
🔄 Suggestion:
Suggested change
| prefixRegexp = regexp.MustCompile(prefix) | |
| const ( | |
| xcbeautify = "xcbeautify" | |
| prefix = `^\[Bitrise.*\].*` | |
| ) |
zsolt-marta-bitrise
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use in xcodecommand/xcbeautify and xcodecommand/xcpretty as well