Track per-attempt HTTP metrics #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented per-attempt tracking for HTTP requests to eliminate retry inflation in duration metrics. Each HTTP attempt (including retries) now generates a separate metric event with an `is_retry` flag. Changes: - Added trackingRoundTripper wrapper that measures per-attempt duration - Updated Tracker.TrackAPIRequest() to include isRetry boolean parameter - Integrated with retryablehttp RequestLogHook to mark retry attempts - Removed aggregate duration tracking from Client.Do() - All attempts now report metrics independently This allows accurate alerting based on individual response times rather than aggregate times that include retry backoff. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
ofalvai
changed the title
tothszabi
approved these changes
Oct 27, 2025
marcell-vida
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Rate-limited requests that get retried multiple times were skewing duration metrics. For example:
Summary
is_retryfieldChanges
trackingRoundTripperthat wraps anet/httptransport and measures per-attempt durationretryablehttplibrary'sRequestLogHookto mark retry attemptsisRetryfieldClient.Do()Testing
roundtripper_test.goverify:is_retryflaggingFollow-up work
Once this change is released in step updates, we'll need to:
step-analyticsservice to useis_retryas a metric tagis_retry=true.is_retry. This will allow us to analyze which projects/orgs have rate limit issues as the event schema already contains the build slug.🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com