Use project-relative path for workspace build settings #300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofalvai
previously approved these changes
Nov 11, 2025
godrei
previously approved these changes
Nov 11, 2025
godrei
reviewed
Nov 11, 2025
| settingsList = append(settingsList, buildSettings{settings: settings, basePath: p.XcWorkspace.Path}) | ||
| // Settings like INFOPLIST_FILE and CODE_SIGN_ENTITLEMENTS are project-relative | ||
| // https://developer.apple.com/documentation/xcode/build-settings-reference#Infoplist-File | ||
| settingsList = append(settingsList, buildSettings{settings: settings, basePath: p.XcProj.Path}) |
Contributor
There was a problem hiding this comment.
Since we always use the project path, when fetching settings with file path value, we can get rid of the buildSettings structure and directly pass the settings map across functions.
…th for build settings
godrei
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.