Skip to content

Conversation

@lpusok
Copy link
Contributor

@lpusok lpusok commented Feb 24, 2022

Checklist

  • I've read and followed the Contribution Guidelines
  • step.yml and README.md is updated with the changes (if needed)

Version

Requires a PATCH version update

Context

Updated filedownloader package to resolve a package dependency inconsistency while updating project-scanner Step. The PR that that helped detect this issue: bitrise-steplib/steps-project-scanner#124.
Resolves: STEP-1804

Solved issue:

❯❯ go build
# github.com/bitrise-steplib/steps-git-clone/gitclone
vendor/github.com/bitrise-steplib/steps-git-clone/gitclone/checkout_method_pr_auto_diff.go:89:58: cannot use filedownloader.New(http.DefaultClient) (type filedownloader.HTTPFileDownloader) as type input.FileDownloader in argument to input.NewFileProvider:
        filedownloader.HTTPFileDownloader does not implement input.FileDownloader (missing GetRemoteContents method)

Decisions

Only the minimum required package was updated at this time.

@lpusok lpusok merged commit 0d16f74 into master Feb 24, 2022
@lpusok lpusok deleted the STEP-1804 branch February 24, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants