Remove run_if condition to allow for use in non-CI environments
#179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russellbstephens
approved these changes
Jul 14, 2022
russellbstephens
left a comment
russellbstephens
left a comment
There was a problem hiding this comment.
Since this PR is 💯 an undoable decision - lets merge
hisaac
added a commit
that referenced
this pull request
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
step.ymlandREADME.mdis updated with the changes (if needed)Version
Seems like a MINOR bump would be appropriate.
Context
@russellbstephens and I were working on the e2e tests of a new step that he's building, and we wanted to do a git clone as a part of one of his e2e tests. We wanted to specify the clone depth, which isn't an option on the simple-git-clone, so we switched over to use this Step instead.
We noticed when trying to run it locally that it kept skipping, and it turns out it's because the Step is set to only be run in CI.
From some discussion in Slack, it sounds like this Step is generally intended to be used in CI, but I think there are instances where we'd want to be able to run it locally. I don't believe it needs to be restricted here.
(fwiw, I know there are workarounds, but I still think this would be a good change so workarounds aren't needed.)
Changes
run_if: .IsCIproperty from the step'sstep.ymlfile.