Added Platform input #382
Merged
Added Platform input #382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofalvai
reviewed
Jun 30, 2025
step.yml
Outdated
| The input value sets xcodebuild's `-scheme` option. | ||
| is_required: true | ||
|
|
||
| - platform: automatic |
Contributor
There was a problem hiding this comment.
I don't have a strong preference, but I'd prefer detect. It suggests how the value is actually found out, unlike automatic, which is a bit too magic.
ofalvai
reviewed
Jun 30, 2025
step.yml
Outdated
| - platform: automatic | ||
| opts: | ||
| title: Platform | ||
| summary: Xcode Platform to build. |
Contributor
There was a problem hiding this comment.
Suggested change
| summary: Xcode Platform to build. | |
| summary: Platform to archive the product for |
ofalvai
reviewed
Jun 30, 2025
step.yml
Outdated
Comment on lines
98
to
102
| Xcode Platform to build. | ||
| If not specified, will try to detect the platform from the project settings. | ||
| Its value sets xcodebuild's `-destination` option. | ||
| Example: `-destination generic/platform=iOS Simulator`. |
Contributor
There was a problem hiding this comment.
Suggested change
| Xcode Platform to build. | |
| If not specified, will try to detect the platform from the project settings. | |
| Its value sets xcodebuild's `-destination` option. | |
| Example: `-destination generic/platform=iOS Simulator`. | |
| Platform to archive the product for. | |
| If set to `detect`, the step will try to detect the platform from the Xcode project settings. | |
| Its value sets xcodebuild's `-destination` option. | |
| Example: `-destination generic/platform=iOS Simulator`. |
ofalvai
reviewed
Jun 30, 2025
step/platform.go
Outdated
| tvOS Platform = "tvOS" | ||
| watchOS Platform = "watchOS" | ||
| visionOS Platform = "visionOS" | ||
| undefinedPlatform Platform = "" |
ofalvai
reviewed
Jun 30, 2025
step/step.go
Outdated
| return out, fmt.Errorf("failed to read project platform: %s: %s", opts.ProjectPath, err) | ||
| if opts.DestinationPlatform == detectPlatform { | ||
| s.logger.TInfof("Platform is set to 'automatic', detecting platform from the project.") | ||
| s.logger.TWarnf("Please set the Platform Input manually to avoid this step in the future.") |
Contributor
There was a problem hiding this comment.
Suggested change
| s.logger.TWarnf("Please set the Platform Input manually to avoid this step in the future.") | |
| s.logger.TWarnf("Define the platform step input manually to avoid this phase in the future.") |
ofalvai
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
step.ymlandREADME.mdis updated with the changes (if needed)Version
Requires a MINOR version update
Context
SDKROOT build setting can be set to
autoinside Xcode project lately, as there is multi-platform target support.Adding Platform solves this as delegating to manual choice of platform is not neccesary.
It also helps to avoid reading a project-level build settings, where passing additional options caused unexpected failures.
Changes
Investigation details
Decisions