Refactor tests and entities to streamline account handling #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed redundant arguments (`Bitrix24AccountStatus`, `createdAt`, `updatedAt`) in test constructors across multiple files. Introduced default handling for these properties within the target entity to simplify initialization and improve code clarity. Updated associated providers and adjusted tests to align with the changes. Signed-off-by: mesilov <mesilov@mesilov-mbp.local>
Initialized default values for `$accountStatus` and `$createdAt` properties in `Bitrix24AccountReferenceEntityImplementation`. Removed redundant arguments `$bitrix24AccountStatus`, `$createdAt`, and `$updatedAt` in `InMemoryContactPersonRepositoryImplementationTest` for simplification. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
The RobotManager class and associated commented-out code have been fully removed as they were unused. This cleanup improves code maintainability and eliminates unnecessary clutter in the codebase. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
mesilov
deleted the
bugfix/141-bug-in-sdk-fix-bitrix24account-unit-test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed redundant arguments (
Bitrix24AccountStatus,createdAt,updatedAt) in test constructors across multiple files. Introduced default handling for these properties within the target entity to simplify initialization and improve code clarity. Updated associated providers and adjusted tests to align with the changes.